Messages in this thread | | | Date | Sat, 18 Dec 1999 04:02:34 -0600 | From | Bill Wendling <> | Subject | Re: [patch] read[bwl] and ioremap problem |
| |
Also sprach Jes Sorensen: } >>>>> "Bill" == Bill Wendling <wendling@ganymede.isdn.uiuc.edu> writes: } } Bill> Hi, I have a first patch in this (the isa_read[bwl] } Bill> thingy). It's my first Linux patch, so I'm kinda nervous about } Bill> it. It's small and attached :). Was this was people had in } Bill> mind? } } This patch is clearly wrong, since the Mac doesn't have IDE on an ISA } bus, thus it shouldn't use those macros. However it's not on a PCI bus } either so it shouldn't use readb/writeb in the first place ;-) } Shoot...there goes my career as an OS writer! :)
Yeah, the whole macide.c file is rather small. Maybe they were using the fact that read/write b are macros which cast the address to (volitile unsigned char/short/int *)? Dunno...anyway, the patch can go away.
-- || Bill Wendling wendling@ganymede.isdn.uiuc.edu
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |