lkml.org 
[lkml]   [1999]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Minor sys_umount fix (changes semantics slightly)
Hi all.

>>> Also, think of the very common case where people mount a CDROM
>>> on /dev/cdrom which is a symlink to /dev/sr0 or /dev/hdc or so.

>> Huh? That's not the issue. The issue is:

>> I use:
>> mount /cdrom
>> ls /cdrom
>> umount /cdrom
>> while:
>> ls -l /cdrom | tr -s '\t' ' '
>> lrwxrwxrwx 1 root root 9 Oct 18 20:46 cdrom -> mnt/cdrom

> I am not sure what you are saying here. The issue is, "should
> the umount system call follow symlinks?".

> Now if in this example the umount system call is executed for
> the path "/cdrom" (which it isnt for the mount/umount that I
> maintain, but that is beside the point, the question is what the
> kernel should do) then it should follow symlinks in order to
> reach the mount point. But that makes Malcolm unhappy, because
> his filesystem has a symlink at the root, and umount would
> happily continue following symlinks past the mount point.

> As it is, umount can be called with both a mount point and a
> special device. But it would be unworkable to have the
> behaviour depend on the type of argument; that type is known
> first after following the symlinks. So, really, we want to
> follow symlinks in all cases, I think.

I'm not sure quite what's being said here, but it looks like different
people are talking about different things. Since I make use of BOTH of
the things I think are being referred to, can I paint my scenario and
ask whether it will continue to work?

First, I have the following:

Q> # ls -Gl /cdrom /dev/cdrom | tr -s '\t' ' ' | cut -d ' ' -f 8-
Q> /cdrom -> /home/ftp/cdrom
Q> /dev/cdrom -> /dev/hdd
Q> # grep cdrom /etc/fstab | tr -s '\t' ' '
Q> /dev/cdrom /home/ftp/cdrom iso9660 defaults,noauto,ro,user
Q> #

I mount the CD drive by typing the following command...

Q> mount /cdrom

...after which it is mounted as per the line from /etc/fstab listed
above, which suits me fine. Will this continue to work?

From my reading of the comments quoted, it looks like one person is
referring to whether mount should follow the /dev/cdrom symlink and
the other is referring to whether it should follow the /cdrom symlink
in my listing, and those serve different purposes.

Best wishes from Riley.

* Copyright (C) 1999, Memory Alpha Systems.
* All rights and wrongs reserved.

+----------------------------------------------------------------------+
| There is something frustrating about the quality and speed of Linux |
| development, ie., the quality is too high and the speed is too high, |
| in other words, I can implement this XXXX feature, but I bet someone |
| else has already done so and is just about to release their patch. |
+----------------------------------------------------------------------+
* http://www.memalpha.cx/Linux/Kernel/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:55    [W:0.035 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site