lkml.org 
[lkml]   [1999]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Common IRQ pitfall results in lockup.
From
Date
>>>>> "Richard" == Richard Gooch <rgooch@ras.ucalgary.ca> writes:

Richard> We could use such a change to fix the problem Rogier
Richard> mentioned: change free_irq() to take struct irqaction *. It's
Richard> a bit harsh, as all drivers would need to be modified, but it
Richard> would ensure the problem would be fixed once and for all. The
Richard> less intrusive option would be to create free_irqentry() and
Richard> encourage driver maintainers to upgrade.

Would be simpler just to disallow interrupts to be registerred with a
NULL argument. That way we will not have any API change and the foul
code will be caught quickly.

Seems to me there's little reason to change the API of
request_irq()/free_irq().

Jes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.062 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site