Messages in this thread | | | Subject | Re: Common IRQ pitfall results in lockup. | From | Jes Sorensen <> | Date | 05 Nov 1999 17:52:02 +0100 |
| |
>>>>> "Richard" == Richard Gooch <rgooch@ras.ucalgary.ca> writes:
Richard> We could use such a change to fix the problem Rogier Richard> mentioned: change free_irq() to take struct irqaction *. It's Richard> a bit harsh, as all drivers would need to be modified, but it Richard> would ensure the problem would be fixed once and for all. The Richard> less intrusive option would be to create free_irqentry() and Richard> encourage driver maintainers to upgrade.
Would be simpler just to disallow interrupts to be registerred with a NULL argument. That way we will not have any API change and the foul code will be caught quickly.
Seems to me there's little reason to change the API of request_irq()/free_irq().
Jes
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |