Messages in this thread | | | Date | Sun, 31 Oct 1999 12:45:30 +0300 | From | Savochkin Andrey Vladimirovich <> | Subject | Re: FD array expansion problem |
| |
I tend to agree with Andrea.
The change of expand_fd_array semantic would affect the code in fork.c without a good reason.
In addition you will have to change expand_fdset semantic for consistency. BTW, the current pre-patch-2.3.25-3 is missing fdset fixes (in open.c) at all.
Best regards Andrey
On Sat, Oct 30, 1999 at 09:13:53PM +0200, Andrea Arcangeli wrote: > Personally I like to continue to ask to expand_fdset this: > > "enlarge the fdset to N bitflags" > > And N is the number of bitflags that you want in the fdset array. > > It's like when you alloc an array in C: > > unsigned long array[1]; > > you want 1 element in the array. > > Also consder that changing the semantic won't improve performances > as the expand_fdset is not going to happen often as it won't enlarge > the fdset of only 1 bit at time ;). > > While instead it may happen often that you fork with a large fd set > allocated, and for fork() the current semantic is the faster one: > > if (size > __FD_SETSIZE) { > expand_fdset(newf, oldf->maxfdset);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |