Messages in this thread | | | Subject | Re: PATCH: Make bootlogo a CONFIG option | From | Jes Sorensen <> | Date | 03 Oct 1999 12:32:33 +0200 |
| |
>>>>> "Patrick" == Patrick Mau <patrick@oscar.prima.de> writes:
Patrick> On Sat, Oct 02, 1999 at 08:24:42PM +0000, Gerhard Mack wrote: >> On 2 Oct 1999, Jes Sorensen wrote: >> >> > Without looking at the patch, I'd claim this is a silly solution >> - you > should rather look at why it gets corrupted instead of >> disabling a > feature. > Or rather a sullution to a diffrent >> problem 8k is quite a savings.. I would like it for other reasons.
Patrick> Hi all, hi Gerhard, hi Jes,
Patrick> this was my first time I submitted a reasonable patch to Patrick> linux-kernel. Why are you discussing it that way ? I just Patrick> made the boot-logo _optional_ ...
Yes, but point out a problem which you fix by disabling a feature, not a very good approach to bug fixing. In fact, adding more config options is not necessarily a good thing either, there are far too many already, one should only add them when there is a good reason - whether this is the case here I do not really think so.
Patrick> The patch was ugly and sub-optimal. At the bottom of my Patrick> original announcment you'll find my remark that I would like Patrick> to clean up the whole fbcon code.
People are already looking at this, join the linux-fbdev@ mailing list.
Jes
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |