lkml.org 
[lkml]   [1999]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-2.3.24 and SERIAL_XMIT_SIZE

Rogier Wolff wrote:
>
> My drivers therefore really should have an
>
> #define XMIT_BUF_SIZE PAGE_SIZE
>
> at the top. The current definition wastes half a page when the page
> size is 8192 (i.e. allocates it, but doesn't use it).... (And it'd
> crash the system when the page size happens to be 2048 on some new
> architecture....)
>
> On the other hand, having too large an output buffer creates higher
> latencies for some applications. Maybe maxing out at 4096 is a good
> idea... #define XMIT_BUF_SIZE (min (PAGE_SIZE, 4096))

Ok, I think that's the best idea. I suggest the following:

#ifndef SERIAL_XMIT_SIZE
#define SERIAL_XMIT_SIZE (MIN(PAGE_SIZE, 4096))
#endif

Adam, please don't worry about the Cyclades driver, I'll take care of
it. Thank you very much for the warning.

Regards,
Ivan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:54    [W:0.038 / U:23.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site