lkml.org 
[lkml]   [1999]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] yet another knfsd reply cache bugfix (plz test)

>
> PROC(readdir, readdirargs, readdirres, none, RC_REPLSTAT),
>
> the encode function is not the void func! It is readdirres So we are
> guaranteed of having a length > 1. So I think this at least is wrong, and
> should be changed to RC_REPLBUFF. I should repeat that I know fairly
> little about this and would love it if you gave it a second look...
>

To follow up on this, I tried the 'recommended change' to my server and
the messages seem to have gone away. I have tested with bonnie from
Solaris 2.6 and linux 2.2.0 (and both simultaneously) and the knfsd is
working flawlessly. I'll attach the patch for the above change.


David

--- linux/fs/nfsd/nfsproc.c~ Wed Jul 22 17:37:36 1998
+++ linux/fs/nfsd/nfsproc.c Fri Jan 29 00:00:42 1999
@@ -515,7 +515,7 @@
PROC(symlink, symlinkargs, void, none, RC_REPLSTAT),
PROC(mkdir, createargs, diropres, fhandle, RC_REPLBUFF),
PROC(rmdir, diropargs, void, none, RC_REPLSTAT),
- PROC(readdir, readdirargs, readdirres, none, RC_REPLSTAT),
+ PROC(readdir, readdirargs, readdirres, none, RC_REPLBUFF),
PROC(statfs, fhandle, statfsres, none, RC_NOCACHE),
};
\
 
 \ /
  Last update: 2005-03-22 13:50    [W:0.103 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site