lkml.org 
[lkml]   [1999]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] some Alpha cleanups
On Sun, Jan 24, 1999 at 12:41:51AM +0000, Alan Cox wrote:
> > *(int *)&id->cur_capacity0 = id->lba_capacity;
> >
> > in ide_disk.c. Such code is terrible.
>
> That one is
>
> > Nobody knows the order of the two shorts in an int.
> > And everyone who does know will be sorry.
> > On some machines this will work, on others it won't.
>
> It works on them all for now - not that it excuses this
>
> What I mean is for a lot of the unaligned trap cases that arent bugs you
> can use the egcs stuff

Agreed. I'll try it this week.

It's difficult to avoid unaligned traps in the networking code due
to the 14-bytes long ethernet header, but in other places they
usually point to the bad code ;-)

Ivan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.027 / U:1.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site