Messages in this thread Patch in this message | | | Date | Sun, 17 Jan 1999 01:17:11 +0100 (CET) | From | Kai Schulte <> | Subject | Re: fix for plip module parameter treatment |
| |
On Sat, 16 Jan 1999, Raoul Boenisch / FB14 / keine Hausanschrift wrote:
> # insmod plip parport=0 > plip: parport0 has no IRQ. ... > Anyway i is the number of registered plip devices. This > is not what we want to search for, but the number of the > parport device pb is.
Thanks, I missed that one -- sorry.
> + plip_searchfor(parport, simple_strtoul(pb->name+7, NULL, 10))) { ... > I had no better idea to get the actual parport device number.
How about pb->number? ;) ============================================================================ --- linux-2.2.0-pre7/drivers/net/plip.c Sun Jan 10 03:11:03 1999 +++ pre7-plip/drivers/net/plip.c Sun Jan 17 01:06:31 1999 @@ -1217,7 +1217,7 @@ plip_searchfor(int list[], int a) { int i; - for (i = 0; i < 3 && list[i] != -1; i++) { + for (i = 0; i < PLIP_MAX && list[i] != -1; i++) { if (list[i] == a) return 1; } return 0; @@ -1240,7 +1240,7 @@ /* If the user feeds parameters, use them */ while (pb) { if ((parport[0] == -1 && (!timid || !pb->devices)) || - plip_searchfor(parport, i)) { + plip_searchfor(parport, pb->number)) { if (i == PLIP_MAX) { printk(KERN_ERR "plip: too many devices\n"); break; ============================================================================ Kai
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |