lkml.org 
[lkml]   [1999]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] getname buffer moved to slab cache
From
Date
In article <Pine.LNX.3.96.990108131523.197B-100000@laser.bogus>,
andrea@e-mind.com (Andrea Arcangeli) writes:
> +void __init namei_init(void)
> +{
> + getname_cache = kmem_cache_create("getname_cache",
> + PAGE_SIZE,
^^^^^^^^^
> + 0,
> + SLAB_HWCACHE_ALIGN,
> + NULL, NULL);
> + if (!getname_cache)
> + panic("cannot create getname cache");
> }


I don't think this patch is a good idea. Slab tries to allocate slabs with
multiple objects, and allocating multi-page objects is notoriously unreliable.
Slab is really only suitable for smaller objects.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.161 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site