Messages in this thread Patch in this message | | | Date | Sat, 10 May 1997 01:45:07 +0100 (BST) | From | Tim Waugh <> | Subject | Re: [2.1.36] parport_procfs.c |
| |
On Fri, 9 May 1997, Matthias Urlichs wrote:
> >> That's not the correct fix. The correct fix is to have {whatever .h file > >> which needs linux/interrupt.h}.h to include that file by itself. > > > >No, Tim's fix is the correct one. We ought to try to avoid introducing > >ever more #includes between header files. It's no great hardship to > > The problem is that one change in header files (i.e. it now requires > another header) can then suddenly result in breakage of unrelated modules > which might not be even distributed with the kernel itself.
Well, okay, how about this one?
--- linux/include/asm-alpha/softirq.h~ Sat May 10 01:39:44 1997 +++ linux/include/asm-alpha/softirq.h Sat May 10 01:41:48 1997 @@ -1,6 +1,8 @@ #ifndef _ALPHA_SOFTIRQ_H #define _ALPHA_SOFTIRQ_H +#include <linux/stddef.h> /* for "NULL" */ + /* The locking mechanism for base handlers, to prevent re-entrancy, * is entirely private to an implementation, it should not be * referenced at all outside of this file. The error that made the change necessary was:
In file included from /home/tim/linux/include/linux/interrupt.h:46, from parport_procfs.c:19: /home/tim/linux/include/asm/softirq.h:33: `NULL' undeclared (first use this function)
Tim. */
| |