Messages in this thread | | | Subject | Re: [PATCH] net: smc91x: Fix m68k kernel compilation for ColdFire CPU | From | Thorsten Blum <> | Date | Thu, 9 May 2024 23:26:46 +0200 |
| |
On 9. May 2024, at 22:36, Andrew Lunn <andrew@lunn.ch> wrote: > This seems like the wrong fix. > > commit d97cf70af09721ef416c61faa44543e3b84c9a55 > Author: Greg Ungerer <gerg@linux-m68k.org> > Date: Fri Mar 23 23:39:10 2018 +1000 > > m68k: use asm-generic/io.h for non-MMU io access functions > > There is nothing really special about the non-MMU m68k IO access functions. > So we can easily switch to using the asm-generic/io.h functions. > > So it rather than put something back which there is an aim to remove, > please find the generic replacement. This _swapw() swaps a 16 bit > word. The generic for that is swab16().
Thanks. I will use ioread16be() and iowrite16be() as suggested by Arnd instead and submit a v2 shortly.
Thorsten
| |