lkml.org 
[lkml]   [2024]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm/msm/dpu: guard ctl irq callback register/unregister
From


On 5/9/2024 10:52 AM, Barnabás Czémán wrote:
> CTLs on older qualcomm SOCs like msm8953 and msm8996 has not got interrupts,
> so better to skip CTL irq callback register/unregister
> make dpu_ctl_cfg be able to define without intr_start.
>

Thanks for the patch.

Have msm8953 and msm8996 migrated to DPU or is there a series planned to
migrate them?

The change itself is correct but without the catalogs for those chipsets
merged, we will never hit this path.


> Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index 489be1c0c704..250d83af53a4 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -298,7 +298,7 @@ static void dpu_encoder_phys_cmd_irq_enable(struct dpu_encoder_phys *phys_enc)
> phys_enc);
> dpu_encoder_phys_cmd_control_vblank_irq(phys_enc, true);
>
> - if (dpu_encoder_phys_cmd_is_master(phys_enc))
> + if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
> dpu_core_irq_register_callback(phys_enc->dpu_kms,
> phys_enc->irq[INTR_IDX_CTL_START],
> dpu_encoder_phys_cmd_ctl_start_irq,
> @@ -311,7 +311,7 @@ static void dpu_encoder_phys_cmd_irq_disable(struct dpu_encoder_phys *phys_enc)
> phys_enc->hw_pp->idx - PINGPONG_0,
> phys_enc->vblank_refcount);
>
> - if (dpu_encoder_phys_cmd_is_master(phys_enc))
> + if (dpu_encoder_phys_cmd_is_master(phys_enc) && phys_enc->irq[INTR_IDX_CTL_START])
> dpu_core_irq_unregister_callback(phys_enc->dpu_kms,
> phys_enc->irq[INTR_IDX_CTL_START]);
>
>
> ---
> base-commit: 704ba27ac55579704ba1289392448b0c66b56258
> change-id: 20240509-ctl_irq-a90b2d7a0bf5
>
> Best regards,

\
 
 \ /
  Last update: 2024-05-27 18:22    [W:0.059 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site