Messages in this thread | | | Date | Thu, 9 May 2024 14:44:36 +0100 | From | Simon Horman <> | Subject | Re: [PATCH net v4] nfc: nci: Fix uninit-value in nci_rx_work |
| |
On Thu, May 09, 2024 at 08:30:33PM +0900, Ryosuke Yasuoka wrote: > syzbot reported the following uninit-value access issue [1] > > nci_rx_work() parses received packet from ndev->rx_q. It should be > validated header size, payload size and total packet size before > processing the packet. If an invalid packet is detected, it should be > silently discarded. > > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > Reported-and-tested-by: syzbot+d7b4dc6cd50410152534@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=d7b4dc6cd50410152534 [1] > Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
I suggest giving time for Krzysztof to review this. But from my side this looks good.
Reviewed-by: Simon Horman <horms@kernel.org>
..
| |