Messages in this thread | | | Date | Thu, 9 May 2024 08:46:55 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 4.19 7/7] iommu: mtk: fix module autoloading |
| |
On Tue, Apr 23, 2024 at 01:39:03PM +0200, Pavel Machek wrote: >Hi! > >> [ Upstream commit 7537e31df80cb58c27f3b6fef702534ea87a5957 ] >> >> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded >> based on the alias from of_device_id table. > >This patch is queued for 4.19 and 5.15, but not 5.10. I believe that's >wrong.
Heh, this is funny. It fails to build on 5.10:
drivers/iommu/mtk_iommu.c:872:1: warning: data definition has no type or storage class 872 | MODULE_DEVICE_TABLE(of, mtk_iommu_of_ids); | ^~~~~~~~~~~~~~~~~~~ drivers/iommu/mtk_iommu.c:872:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] drivers/iommu/mtk_iommu.c:872:1: warning: parameter names (without types) in function declaration cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:286: drivers/iommu/mtk_iommu.o] Error 1
But not on any of the older trees.
-- Thanks, Sasha
| |