Messages in this thread | | | Date | Thu, 9 May 2024 15:12:25 +0530 | From | Ratheesh Kannoth <> | Subject | Re: [PATCH net-next v3] net: Add sysfs atttribute for max_mtu |
| |
On 2024-05-09 at 14:41:23, Shradha Gupta (shradhagupta@linux.microsoft.com) wrote: > For drivers like MANA, max_mtu value is populated with the value of > maximum MTU that the underlying hardware can support. IIUC, this reads dev->mtu. you can read the same using ifconfig, or any thing that uses SIOCGIFMTU. why do you need to add a new sysfs ?
> Exposing this attribute as sysfs param, would be helpful in debugging > and customization of config issues with such drivers. > > --- a/net/core/net-sysfs.c > +++ b/net/core/net-sysfs.c > @@ -114,6 +114,7 @@ NETDEVICE_SHOW_RO(addr_len, fmt_dec); > NETDEVICE_SHOW_RO(ifindex, fmt_dec); > NETDEVICE_SHOW_RO(type, fmt_dec); > NETDEVICE_SHOW_RO(link_mode, fmt_dec); > +NETDEVICE_SHOW_RO(max_mtu, fmt_dec); > > static ssize_t iflink_show(struct device *dev, struct device_attribute *attr, > char *buf) > @@ -660,6 +661,7 @@ static struct attribute *net_class_attrs[] __ro_after_init = { > &dev_attr_ifalias.attr, > &dev_attr_carrier.attr, > &dev_attr_mtu.attr, > + &dev_attr_max_mtu.attr, > &dev_attr_flags.attr, > &dev_attr_tx_queue_len.attr, > &dev_attr_gro_flush_timeout.attr, > -- > 2.34.1 >
| |