Messages in this thread | | | Date | Thu, 9 May 2024 17:15:03 +0800 | From | Alina Yu <> | Subject | Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout |
| |
On Wed, May 08, 2024 at 08:53:34PM +0900, Mark Brown wrote: > On Wed, May 08, 2024 at 02:54:02PM +0800, Alina Yu wrote: > > > May I modify the code into this ? > > I'll add 'richtek,fixed-microvolt' property in dtsi; remove 'regulator-min-microvolt' and 'regulator-max-microvolt' > > to prevent fail caused by constraints->apply_uV. > > Adding the new property seems fine. You still need to permit the > min/max microvolt properties for the case where the regulator is in > normal mode and can vary, you could write rules that ensure that the > constraints line up in the case where a fixed voltage is specified but > I'm not sure it's worth the effort.
Or may I add the following condition to check the constraints.min_uV and constraints.max_uV match the specified fixed voltage ?
+ u32 fixed_uV; int ret, i;
..
+ /* specify working fixed voltage if the propery exists */ + ret = of_property_read_u32(match->of_node, "richtek,fixed-microvolt", &fixed_uV); + + if (!ret) { + if (fixed_uV != init_data->constraints.min_uV || + fixed_uV != init_data->constraints.max_uV) + return -EINVAL; + desc->n_voltages = 1; + desc->fixed_uV = fixed_uV;
..
Thanks, Alina
| |