lkml.org 
[lkml]   [2024]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge
From
On 08/05/2024 10:13, Dmitry Baryshkov wrote:
> On Wed, 8 May 2024 at 10:38, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 07/05/2024 21:20, Abhinav Kumar wrote:
>>>
>>>
>>> On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote:
>>>> On 07/05/2024 18:30, Venkata Prahlad Valluru wrote:
>>>>> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with
>>>>> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24.
>>>>> Bridge supplies are Vdd connected to input supply directly
>>>>> and vcc to L11c. Enable HDMI output, bridge and corresponding
>>>>> DSI output.
>>>>>
>>>>> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com>
>>>>> ---
>>>>> v3: - Updated commit text
>>>>> - Arranged nodes in alphabetical order
>>>>> - Fixed signoff
>>>>> - Fixed drive strength for lt9611_irq_pin
>>>>> - Removed 'label' from hdmi-connector, which is optional
>>>>
>>>> Please respond to each Bjorn comment and explain how did you implement it...
>>>>
>>>
>>> Yes, agreed. Even though it seems like you mostly just agreed to mine
>>> and Bjorn's suggestions and decided to implement all those in v3 , it
>>> would have been better to explicitly ack them or tell why you agreed or
>>> what went wrong that you had not done it in v2 itself to close the loop.
>>
>> The problem is that one or more were ignored... By responding to each of
>> them, I hope they will be finally read and understood instead of
>> repeating the same mistake three times.
>
> I found a mistake that was repeated two times. This leaves me
> wondering which mistake was repeated three times.

That was about future, I was expecting v4 as in-reply-to :)

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2024-05-09 10:31    [W:0.063 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site