Messages in this thread | | | Date | Wed, 8 May 2024 21:17:59 +0200 | Subject | Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS | From | Krzysztof Kozlowski <> |
| |
On 08/05/2024 21:11, Arnd Bergmann wrote: > On Wed, May 8, 2024, at 20:44, Krzysztof Kozlowski wrote: >> On 08/05/2024 20:28, Andy Shevchenko wrote: >>> On Wed, May 08, 2024 at 08:15:00PM +0200, Krzysztof Kozlowski wrote: >>>> On 08/05/2024 19:53, Andy Shevchenko wrote: >>>>> On Sun, Apr 14, 2024 at 05:49:57PM +0200, Krzysztof Kozlowski wrote: >>>>>> The ID table already has respective entry and MODULE_DEVICE_TABLE and >>>>>> creates proper alias for SPI driver. Having another MODULE_ALIAS causes >>>>>> the alias to be duplicated. >>> >>> ... >>> >>>>>> MODULE_ALIAS("spi:93xx46"); >>>>> >>>>> I was stumbled over this (leftover?). >>>>> Commit message doesn't elaborate this bit. >>>>> Any comments? >>>> >>>> It is not present in ID table and commit msg removes only duplicated >>>> aliases. That alias has meaning - someone might be actually relying on it. >>> >>> It seems no users for it. The only user of platform data of this EEPROM uses >>> board files which AFAIU bypasses modalias matching. >> >> I don't think that's correct. The modalias of SPI board is there on >> purpose. > > Right, but I think a better workaround would have been to change > the board_info to pick a modalias that is part of the ID table: > > --- a/drivers/misc/eeprom/digsy_mtc_eeprom.c > +++ b/drivers/misc/eeprom/digsy_mtc_eeprom.c > @@ -76,7 +76,7 @@ static struct gpiod_lookup_table eeprom_spi_gpiod_table = { > > static struct spi_board_info digsy_mtc_eeprom_info[] __initdata = { > { > - .modalias = "93xx46", > + .modalias = "eeprom-93xx46", > .max_speed_hz = 1000000, > .bus_num = EE_SPI_BUS_NUM, > .chip_select = 0, >
That's kind of independent change. This commit *only* removed duplicated aliases, thus should have not functional impact except dropping redundant code. What you propose is to change spi board matching, which is reasonable, just a different thing.
Best regards, Krzysztof
| |