Messages in this thread | | | Date | Wed, 8 May 2024 09:58:42 -0700 | Subject | Re: [PATCH 1/3] mm/memory-failure: try to send SIGBUS even if unmap failed | From | Jane Chu <> |
| |
On 5/8/2024 12:47 AM, Miaohe Lin wrote:
> On 2024/5/2 7:24, Jane Chu wrote: >> For years when it comes down to kill a process due to hwpoison, >> a SIGBUS is delivered only if unmap has been successful. >> Otherwise, a SIGKILL is delivered. And the reason for that is >> to prevent the involved process from accessing the hwpoisoned >> page again. >> >> Since then a lot has changed, a hwpoisoned page is marked and >> upon being re-accessed, the process will be killed immediately. >> So let's take out the '!unmap_success' factor and try to deliver >> SIGBUS if possible. >> >> Signed-off-by: Jane Chu <jane.chu@oracle.com> >> --- >> mm/memory-failure.c | 13 ++++--------- >> 1 file changed, 4 insertions(+), 9 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 9e62a00b46dd..7fcf182abb96 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -519,19 +519,14 @@ void add_to_kill_ksm(struct task_struct *tsk, struct page *p, >> * Also when FAIL is set do a force kill because something went >> * wrong earlier. > Since @fail is removed, above comment should be removed too. > Thanks. > .
Good catch, will do.
Thanks!
-jane
| |