Messages in this thread | | | Date | Wed, 8 May 2024 11:51:02 -0400 | Subject | Re: [PATCH v4 0/4] RAS: ATL: DF 4.5 NP2 Denormalization | From | Yazen Ghannam <> |
| |
On 5/6/24 11:46 AM, John Allen wrote: > Implement non-power-of-two denormalization for Data Fabric 4.5 in the > AMD address translation library. > > Tree: > git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git > Base commit: > bd17b7c34fadef645becde1245b9394f69f31702 > (origin/edac-amd-atl) > > v2: > - Fix compilation error. > - Make remove_base_and_hole the inverse of add_base_and_hole. > - Move all map validation checks to validate_address_map at the > beginning of translation > v3: > - Fix bug where the legacy hole was not getting removed properly. > - Minor rework of functions for matching the normalized address and > logical cs fabric id. > v4: > - Merge common cases in map validation function. > - Fix map validation for cases that don't have explicit checks. > > John Allen (4): > RAS/AMD/ATL: Read DRAM hole base early > RAS/AMD/ATL: Expand helpers for adding and removing base and hole > RAS/AMD/ATL: Validate address map when information is gathered > RAS/AMD/ATL: Implement DF 4.5 NP2 denormalization > > drivers/ras/amd/atl/core.c | 48 +-- > drivers/ras/amd/atl/dehash.c | 43 --- > drivers/ras/amd/atl/denormalize.c | 523 ++++++++++++++++++++++++++++++ > drivers/ras/amd/atl/internal.h | 45 +++ > drivers/ras/amd/atl/map.c | 97 ++++++ > drivers/ras/amd/atl/system.c | 21 ++ > 6 files changed, 711 insertions(+), 66 deletions(-) >
This set looks good to me.
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks, Yazen
| |