Messages in this thread | | | Date | Wed, 8 May 2024 16:41:03 +0200 | Subject | Re: [PATCH v1 1/1] dimlib: Use *-y instead of *-objs in Makefile | From | Alexander Lobakin <> |
| |
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Wed, 8 May 2024 17:29:42 +0300
> *-objs suffix is reserved rather for (user-space) host programs while > usually *-y suffix is used for kernel drivers (although *-objs works > for that purpose for now). > > Let's correct the old usages of *-objs in Makefiles. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> --- > > Reported by Olek. As I said him this is correct change which is > documented in Documentation/kbuild/makefiles.rst "Composite Host > Programs" (mind the meaning of the word "host"!). > > lib/dim/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/dim/Makefile b/lib/dim/Makefile > index c4cc4026c451..5b9bfaac7ac1 100644 > --- a/lib/dim/Makefile > +++ b/lib/dim/Makefile > @@ -4,4 +4,4 @@ > > obj-$(CONFIG_DIMLIB) += dimlib.o > > -dimlib-objs := dim.o net_dim.o rdma_dim.o > +dimlib-y := dim.o net_dim.o rdma_dim.o
Thanks, Olek
| |