Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v3 4/4] selftests/mm: Add new testcases for pkeys | Date | Wed, 08 May 2024 14:55:40 +0200 |
| |
On Tue, May 07 2024 at 18:04, Aruna Ramakrishna wrote: >> On May 7, 2024, at 9:56 AM, Thomas Gleixner <tglx@linutronix.de> wrote: >> >> On Tue, May 07 2024 at 14:05, Thomas Gleixner wrote: >>> On Thu, Apr 25 2024 at 18:05, Aruna Ramakrishna wrote: >>>> especially with pkey 0 disabled. >>>> >>>> Signed-off-by: Keith Lucas <keith.lucas@oracle.com> >>>> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com> >> >> Forgot to mention that this Signed-off-by chain is invalid. > > Apologies for what is probably an obvious question. > > Keith Lucas developed the testcases in the new file pkey_sighandler_testsc. > > I added them to tools/testing/selftests/mm (i.e. just the changes > to Makefile, protection_keys.c and some comments etc.). > > So should I change this to: > > Co-developed-by: Keith Lucas <keith.lucas@oracle.com> > Signed-off-by: Keith Lucas <keith.lucas@oracle.com> > Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
If Keith developed them, then you probably want to credit him as author.
[ aruna: Adopted to upstream ]
Signed-off-by: Keith Lucas <keith.lucas@oracle.com> Signed-off-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
Or split out the pkey helper changes into a separate patch which is authored by you.
Either way works just fine.
Thanks,
tglx
| |