lkml.org 
[lkml]   [2024]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH net-next v17 12/13] realtek: Update the Makefile and Kconfig in the realtek folder
On Tue, May 07, 2024 at 09:44:14AM +0000, Justin Lai wrote:
> > On Thu, May 02, 2024 at 05:18:46PM +0800, Justin Lai wrote:
> > > 1. Add the RTASE entry in the Kconfig.
> > > 2. Add the CONFIG_RTASE entry in the Makefile.
> > >
> > > Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> > > ---
> > > drivers/net/ethernet/realtek/Kconfig | 17 +++++++++++++++++
> > > drivers/net/ethernet/realtek/Makefile | 1 +
> > > 2 files changed, 18 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/realtek/Kconfig
> > > b/drivers/net/ethernet/realtek/Kconfig
> > > index 93d9df55b361..57ef924deebd 100644
> > > --- a/drivers/net/ethernet/realtek/Kconfig
> > > +++ b/drivers/net/ethernet/realtek/Kconfig
> > > @@ -113,4 +113,21 @@ config R8169
> > > To compile this driver as a module, choose M here: the module
> > > will be called r8169. This is recommended.
> > >
> > > +config RTASE
> > > + tristate "Realtek Automotive Switch
> > 9054/9068/9072/9075/9068/9071 PCIe Interface support"
> > > + depends on PCI
> > > + select CRC32
> >
> > Hi Justin,
> >
> > I believe that you also need:
> >
> > select PAGE_POOL
> >
> > As the driver uses page_pool_alloc_pages()
> >
> > FWIIW, I observed this when using a config based on make tinyconfig with PCI
> > and NET enabled, all WiFi drivers disabled, and only and only this Ethernet
> > driver enabled.
> >
> > > + help
> > > + Say Y here if you have a Realtek Ethernet adapter belonging to
> > > + the following families:
> > > + RTL9054 5GBit Ethernet
> > > + RTL9068 5GBit Ethernet
> > > + RTL9072 5GBit Ethernet
> > > + RTL9075 5GBit Ethernet
> > > + RTL9068 5GBit Ethernet
> > > + RTL9071 5GBit Ethernet
> > > +
> > > + To compile this driver as a module, choose M here: the module
> > > + will be called rtase. This is recommended.
> >
> > The advice above to chose Y and M seem to conflict.
> > Perhaps this can be edited somehow.
> >
>
> Hi Simon,
> I would like to ask if it would be clearer if I changed it to the following?
>
> config RTASE
> tristate "Realtek Automotive Switch 9054/9068/9072/9075/9068/9071 PCIe Interface support"
> depends on PCI
> select CRC32
> select PAGE_POOL
> help
> Say Y here and it will be compiled and linked with the kernel
> if you have a Realtek Ethernet adapter belonging to the
> following families:
> RTL9054 5GBit Ethernet
> RTL9068 5GBit Ethernet
> RTL9072 5GBit Ethernet
> RTL9075 5GBit Ethernet
> RTL9068 5GBit Ethernet
> RTL9071 5GBit Ethernet
>
> To compile this driver as a module, choose M here: the module
> will be called rtase. This is recommended.

Thanks Justin,

Yes, I think that addresses my concern.

\
 
 \ /
  Last update: 2024-05-08 10:42    [W:0.095 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site