Messages in this thread | | | Date | Tue, 7 May 2024 10:30:55 +0200 | From | Nicolas Schier <> | Subject | Re: [PATCH 1/2] rapidio: specify the type for tristate choice explicitly |
| |
On Sat, Apr 27, 2024 at 07:42:30PM +0900, Masahiro Yamada wrote: > If the type of choice is not specified, it is implied by the first > entry within the choice block. > > In this case, the first (and only) entry, RAPIDIO_ENUM_BASIC, is > tristate, hence this choice behaves as tristate. > > Kconfig will stop this implication because it has a bug, and 99% of > choice use cases are bool. In fact, this is the only instance of > tristate choice in the kernel. > > Before transitioning the default choice type to 'bool', specify the > type explicitly for this case. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > ---
Reviewed-by: Nicolas Schier <n.schier@avm.de>
| |