Messages in this thread | | | Date | Tue, 7 May 2024 12:20:30 -0700 | Subject | Re: [PATCH v3] arm64: dts: qcom: qcs6490-rb3gen2: enable hdmi bridge | From | Abhinav Kumar <> |
| |
On 5/7/2024 9:35 AM, Krzysztof Kozlowski wrote: > On 07/05/2024 18:30, Venkata Prahlad Valluru wrote: >> Rb3Gen2 has a lt9611uxc DSI-to-HDMI bridge on i2c0, with >> reset gpio from pm7250b gpio2 and irq gpio from tlmm gpio24. >> Bridge supplies are Vdd connected to input supply directly >> and vcc to L11c. Enable HDMI output, bridge and corresponding >> DSI output. >> >> Signed-off-by: Venkata Prahlad Valluru <quic_vvalluru@quicinc.com> >> --- >> v3: - Updated commit text >> - Arranged nodes in alphabetical order >> - Fixed signoff >> - Fixed drive strength for lt9611_irq_pin >> - Removed 'label' from hdmi-connector, which is optional > > Please respond to each Bjorn comment and explain how did you implement it... >
Yes, agreed. Even though it seems like you mostly just agreed to mine and Bjorn's suggestions and decided to implement all those in v3 , it would have been better to explicitly ack them or tell why you agreed or what went wrong that you had not done it in v2 itself to close the loop.
> Best regards, > Krzysztof >
| |