Messages in this thread | | | Date | Mon, 6 May 2024 23:06:17 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] xfs: check for negatives in xfs_exchange_range_checks() |
| |
On Sat, May 04, 2024 at 02:27:36PM +0300, Dan Carpenter wrote: > The fxr->file1_offset and fxr->file2_offset variables come from the user > in xfs_ioc_exchange_range(). They are size loff_t which is an s64. > Check the they aren't negative. > > Fixes: 9a64d9b3109d ("xfs: introduce new file range exchange ioctl")
In this commit file1_offset and file2_offset are u64. They used to be u64 in the initial submission, but we changed that as part of the review process.
| |