Messages in this thread | | | Date | Fri, 3 May 2024 10:25:26 +0300 | Subject | Re: [PATCH v1 1/6] dt-bindings: ROHM BD96801 PMIC regulators | From | Matti Vaittinen <> |
| |
On 5/3/24 07:54, Matti Vaittinen wrote: > Hi Conor, > > On 5/2/24 19:20, Conor Dooley wrote: >> On Tue, Apr 30, 2024 at 02:59:50PM +0300, Matti Vaittinen wrote: >> >> Krzysztof had some comments on the buck/ldo node names > > I think Krzysztof pointed out that the regulator-name property should > not match the data-sheet but the board. If he had something to say about > the node names, then I've missed his comment! > >> and on the >> initial value properties that I'm not sure if have been addressed, so >> gonna leave this series to him. > > Thanks for pointing out I may have missed addressing some of his > concerns. I though I fixed all issues he pointed to me but it may be I > missed some - or accidentally dropped some change(s) when merging fixes > from the 'experimental' branch to the 'simple'. I'll revise Krzysztof's > feedback to the RFC before sending the next version!
You were right Conor. I checked it and yes, I omitted a few of the fixes to regulator bindings. Please skip reviewing this version of these bindings, I'll handle the rest of the comments in next one!
Yours, -- Matti
-- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
| |