lkml.org 
[lkml]   [2024]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFT PATCH v2 25/48] drm/panel: samsung-atna33xc20: Don't call unprepare+disable at shutdown/remove
    Date
    It's the responsibility of a correctly written DRM modeset driver to
    call drm_atomic_helper_shutdown() at shutdown time and that should be
    disabling / unpreparing the panel if needed. Panel drivers shouldn't
    be calling these functions themselves.

    A recent effort was made to fix as many DRM modeset drivers as
    possible [1] [2] [3] and most drivers are fixed now.

    A grep through mainline for compatible strings used by this driver
    indicates that it is used by Qualcomm boards. The Qualcomm driver
    appears to be correctly calling drm_atomic_helper_shutdown() so we can
    remove the calls.

    [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
    [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
    [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    ---

    Changes in v2:
    - Only handle 1 panel per patch.
    - Split removal of prepared/enabled from handling of remove/shutdown.

    drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 12 ------------
    1 file changed, 12 deletions(-)

    diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
    index a322dd0a532f..9a482a744b8c 100644
    --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
    +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
    @@ -327,21 +327,10 @@ static void atana33xc20_remove(struct dp_aux_ep_device *aux_ep)
    struct atana33xc20_panel *panel = dev_get_drvdata(dev);

    drm_panel_remove(&panel->base);
    - drm_panel_disable(&panel->base);
    - drm_panel_unprepare(&panel->base);

    drm_edid_free(panel->drm_edid);
    }

    -static void atana33xc20_shutdown(struct dp_aux_ep_device *aux_ep)
    -{
    - struct device *dev = &aux_ep->dev;
    - struct atana33xc20_panel *panel = dev_get_drvdata(dev);
    -
    - drm_panel_disable(&panel->base);
    - drm_panel_unprepare(&panel->base);
    -}
    -
    static const struct of_device_id atana33xc20_dt_match[] = {
    { .compatible = "samsung,atna33xc20", },
    { /* sentinal */ }
    @@ -362,7 +351,6 @@ static struct dp_aux_ep_driver atana33xc20_driver = {
    },
    .probe = atana33xc20_probe,
    .remove = atana33xc20_remove,
    - .shutdown = atana33xc20_shutdown,
    };

    static int __init atana33xc20_init(void)
    --
    2.45.0.rc1.225.g2a3ae87e7f-goog

    \
     
     \ /
      Last update: 2024-05-27 18:15    [W:2.903 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site