lkml.org 
[lkml]   [2024]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property
Hi Andrew,

On Tue, 30 Apr 2024 18:31:46 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> > We have the same construction with the pinctrl driver used in the LAN966x
> > Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml
> >
> > The reset name is 'switch' in the pinctrl binding.
> > I can use the same description here as the one present in the pinctrl binding:
> > description: Optional shared switch reset.
> > and keep 'switch' as reset name here (consistent with pinctrl reset name).
> >
> > What do you think about that ?
>
> It would be good to document what it is shared with. So it seems to be
> the switch itself, pinctl and MDIO? Anything else?
>

To be honest, I know that the GPIO controller (microchip,sparx5-sgpio) is
impacted but I don't know if anything else is impacted by this reset.
I can update the description with:
description:
Optional shared switch reset.
This reset is shared with at least pinctrl, GPIO, MDIO and the switch
itself.

Does it sound better ?

Best regards
Hervé

\
 
 \ /
  Last update: 2024-05-27 18:12    [W:0.111 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site