Messages in this thread | | | Date | Wed, 15 May 2024 11:06:43 -0600 | From | "Lyndon Sanche" <> | Subject | Re: [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform_profile |
| |
On Sun, May 12, 2024, at 12:05 PM, Armin Wolf wrote: > Am 11.05.24 um 04:36 schrieb Lyndon Sanche: >
>> +static int thermal_init(void) >> +{ >> + int ret; >> + int supported_modes; >> + >> + /* If thermal commands not supported, exit without error */ >> + if (!dell_laptop_check_supported_cmds(CLASS_INFO)) >> + return 0; >> + >> + /* If thermal modes not supported, exit without error */ >> + ret = thermal_get_supported_modes(&supported_modes); >> + if (ret < 0) >> + return ret; > > Hi, > > the function dell_smbios_error() says that when a specific functionality is > not supported, -ENXIO is returned. > > Please treat this as "no thermal modes supported", since checking if CLASS_INFO > is supported is not enough (CLASS_INFO is also used by other functionality like > rfkill, so machines might support CLASS_INFO but not USTT). > > Thanks, > Armin Wolf >
Armin:
Thank you for this. I will include this in the next revision.
Thanks,
Lyndon
| |