Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 14 May 2024 21:38:57 +0530 | Subject | Re: [PATCH] clk: qcom: apss-ipq-pll: remove 'config_ctl_hi_val' from Stromer pll configs | From | Kathiravan Thirumoorthy <> |
| |
On 5/14/2024 12:14 AM, Gabor Juhos wrote: > 2024. 05. 10. 18:25 keltezéssel, Kathiravan Thirumoorthy írta: >> >> >> On 5/10/2024 12:23 AM, Konrad Dybcio wrote: >>> On 9.05.2024 10:08 AM, Gabor Juhos wrote: >>>> Since the CONFIG_CTL register is only 32 bits wide in the Stromer >>>> and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the >>>> IPQ5018 and IPQ5332 configurations are not used so remove those. >>>> >>>> No functional changes. >>>> >>>> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> >>>> --- >>> >>> Hm, it sounds suspicious that we'd have these settings then.. Could somebody from >>> QC please confirm that everything's alright here? >> >> >> I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register >> is not implemented. I see offset of CONFIG_CTL_U register is removed in the >> change[1] by Gabor. > > Thanks for confirming! > >> >> Given that, should we also drop the pll_has_64bit_config() if block from >> clk_stromer_pll_configure function? > > If we can be sure, that there will be no Stromer PLLs which implements that > register we can drop the check. Also, since the SUPPORTS_FSM_MODE flag is not > set for any of the Stromer (Plus) Plls supported currently, the related check > can be dropped as well. > > However I would keep that as is for now. I'm planning to remove the > clk_stromer_pll_configure() function entirely but that needs a bunch of > preparatory patches which I'm working on at the moment. >
It was Stephen's suggestion[1] to introduce the clk_stromer_pll_configure() to avoid touching the clk_alpha_pll_configure() which has been used by many PLLs. However if we have a valid points to remove this API, then yes.
[1] https://lore.kernel.org/linux-arm-msm/fd150fa2b35e1e07808e3d1e67e1def7.sboyd@kernel.org/
>> >> Nevertheless, for this patch >> >> Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com> > > Thank you! > > Regards, > Gabor
| ![\](/images/icornerr.gif) |