Messages in this thread | | | Date | Fri, 10 May 2024 14:42:53 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v22 2/5] ring-buffer: Introducing ring-buffer mapping functions |
| |
On Fri, 10 May 2024 12:03:12 +0100 Vincent Donnefort <vdonnefort@google.com> wrote:
> > I'm not particularly happy about us calling vm_insert_pages with NULL > > pointers stored in pages. > > > > Should we instead do > > > > if (WARN_ON_ONCE(s >= nr_subbufs)) { > > err = -EINVAL; > > goto out; > > } > > > > ? > > I could also nr_pages = p in the event of s >= nr_subbufs... but that > really that shouldn't happen so let's return an error.
I'm good with this. It should never happen anyway.
-- Steve
| |