Messages in this thread | | | Date | Fri, 10 May 2024 12:30:33 +0100 | From | Simon Horman <> | Subject | Re: [PATCH net-next v2 12/14] net: qede: use faked extack in qede_flow_spec_to_rule() |
| |
On Wed, May 08, 2024 at 02:34:00PM +0000, Asbjørn Sloth Tønnesen wrote: > Since qede_parse_flow_attr() now does error reporting > through extack, then give it a fake extack and extract the > error message afterwards if one was set. > > The extracted error message is then passed on through > DP_NOTICE(), including messages that was earlier issued > with DP_INFO(). > > This fake extack approach is already used by > mlxsw_env_linecard_modules_power_mode_apply() in > drivers/net/ethernet/mellanox/mlxsw/core_env.c > > Only compile tested. > > Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> > > --- > Note: > Even through _msg is marked in include/linux/netlink.h as > "don't access directly, use NL_SET_ERR_MSG", then the comment > above NL_SET_ERR_MSG, seams to indicate that it should be fine > to access it directly if for reading, as is done other places. > I could also add a NL_GET_ERR_MSG but I would rather not do that > in this series.
Reviewed-by: Simon Horman <horms@kernel.org>
| |