Messages in this thread | | | Date | Fri, 26 Apr 2024 08:23:02 +0200 | From | Maxime Ripard <> | Subject | Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs |
| |
Hi,
On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > On 2024/4/26 03:10, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > > > On 2024/4/25 22:26, Andy Shevchenko wrote: > > > > It seems driver missed the point of proper use of device property APIs. > > > > Correct this by updating headers and calls respectively. > > > You are using the 'seems' here exactly saying that you are not 100% sure. > > > > > > Please allow me to tell you the truth: This patch again has ZERO effect. > > > It fix nothing. And this patch is has the risks to be wrong. > > Huh?! Really, stop commenting the stuff you do not understand. > > I'm actually a professional display drivers developer at the downstream > in the past, despite my contribution to upstream is less. But I believe > that all panel driver developers know what I'm talking about. So please > have take a look at my replies.
Most of the interactions you had in this series has been uncalled for. You might be against a patch, but there's no need to go to such length.
As far as I'm concerned, this patch is fine to me in itself, and I don't see anything that would prevent us from merging it.
Maxime [unhandled content-type:application/pgp-signature] | |