Messages in this thread | | | From | Ping-Ke Shih <> | Subject | RE: [PATCH wireless] wifi: rtw89: Un-embed dummy device | Date | Thu, 25 Apr 2024 06:15:21 +0000 |
| |
Kalle Valo <kvalo@kernel.org> wrote: > Kalle Valo <kvalo@kernel.org> writes: > > > Ping-Ke Shih <pkshih@realtek.com> writes: > > > >> Breno Leitao <leitao@debian.org> wrote: > >>> Embedding net_device into structures prohibits the usage of flexible > >>> arrays in the net_device structure. For more details, see the discussion > >>> at [1]. > >>> > >>> Un-embed the net_device from the private struct by converting it > >>> into a pointer. Then use the leverage the new alloc_netdev_dummy() > >>> helper to allocate and initialize dummy devices. > >>> > >>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ > >>> > >>> Signed-off-by: Breno Leitao <leitao@debian.org> > >> > >> I think this patch should go via net-next tree, because wireless-next tree > >> doesn't have patch of dummy devices yet. > >> > >> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > > > FWIW I sent the wireless-next pull request yesterday and once it pulled > > we will fast forward wireless-next to latest net-next. > > Oh, I just realised that this is not CCed to netdev so their patchwork > won't even see the patch. Ping, I recommend that you wait for the > dependency commits to trickle down to your tree and then apply the > patch. That's the simplest approach and no need to resend anything.
Okay. If we don't hurry to get this patch merged, I will apply this patch to my tree.
| |