lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch V2 07/50] posix-cpu-timers: Split up posix_cpu_timer_get()
    Date
    Oleg Nesterov <oleg@redhat.com> writes:

    > On 04/11, Thomas Gleixner wrote:
    >>
    >> In preparation for addressing issues in the timer_get() and timer_set()
    >> functions of posix CPU timers.
    >
    > Cough... I must have missed something, but posix_cpu_timer_get()
    > doesn't look right with or without this trivial patch.
    >
    > It doesn't initialize itp->it_value if cpu_timer_getexpires() == 0,
    > this means that sys_timer_gettime() will copy the uninitialized
    > cur_setting->it_value on the stack to userspace?

    The initialization of itp is already done by the callsites.
    do_timer_settime() in posix-timers.c as well as do_cpu_nanosleep() in
    posix-cpu-timers.c execute a memset before calling
    posix_cpu_timer_get(). So this should be fine - or did I miss something
    here?

    Thanks,

    Anna-Maria


    \
     
     \ /
      Last update: 2024-05-27 16:41    [W:2.375 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site