lkml.org 
[lkml]   [2024]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v8 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface
    On Tue, 16 Apr 2024 19:23:02 -0700
    Jakub Kicinski <kuba@kernel.org> wrote:

    > On Sun, 14 Apr 2024 16:21:55 +0200 Kory Maincent wrote:
    > > + !(pse_has_podl(phydev->psec))) {
    > > + NL_SET_ERR_MSG_ATTR(info->extack,
    > > + tb[ETHTOOL_A_PODL_PSE_ADMIN_CONTROL],
    > > + "setting PoDL PSE admin control not
    > > supported");
    > > + return -EOPNOTSUPP;
    > > + }
    > > + if (tb[ETHTOOL_A_C33_PSE_ADMIN_CONTROL] &&
    > > + !(pse_has_c33(phydev->psec))) {
    >
    > nit: unnecessary parenthesis around the function call

    Right, thanks for spotting it!

    Regards,
    --
    Köry Maincent, Bootlin
    Embedded Linux and kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2024-05-27 16:41    [W:3.869 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site