lkml.org 
[lkml]   [2024]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 10/18] ACPI: Warn when the present bit changes but the feature is not enabled
    Date
    From: James Morse <james.morse@arm.com>

    ACPI firmware can trigger the events to add and remove CPUs, but the
    OS may not support this.

    Print an error message when this happens.

    This gives early warning on arm64 systems that don't support
    CONFIG_ACPI_HOTPLUG_PRESENT_CPU, as making CPUs not present has
    side effects for other parts of the system.

    Signed-off-by: James Morse <james.morse@arm.com>
    Reviewed-by: Gavin Shan <gshan@redhat.com>
    Tested-by: Miguel Luis <miguel.luis@oracle.com>
    Tested-by: Vishnu Pajjuri <vishnu@os.amperecomputing.com>
    Tested-by: Jianyong Wu <jianyong.wu@arm.com>
    Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    ---
    v5: No change
    ---
    drivers/acpi/acpi_processor.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
    index 0403eddb3f80..3fb167ee9807 100644
    --- a/drivers/acpi/acpi_processor.c
    +++ b/drivers/acpi/acpi_processor.c
    @@ -187,8 +187,10 @@ static int acpi_processor_make_present(struct acpi_processor *pr)
    {
    int ret;

    - if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU))
    + if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU)) {
    + pr_err_once("Changing CPU present bit is not supported\n");
    return -ENODEV;
    + }

    if (invalid_phys_cpuid(pr->phys_id))
    return -ENODEV;
    @@ -466,8 +468,10 @@ static void acpi_processor_make_not_present(struct acpi_device *device)
    {
    struct acpi_processor *pr;

    - if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU))
    + if (!IS_ENABLED(CONFIG_ACPI_HOTPLUG_CPU)) {
    + pr_err_once("Changing CPU present bit is not supported");
    return;
    + }

    pr = acpi_driver_data(device);
    if (pr->id >= nr_cpu_ids)
    --
    2.39.2

    \
     
     \ /
      Last update: 2024-05-27 16:38    [W:2.743 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site