Messages in this thread | | | From | Dario Binacchi <> | Date | Sat, 6 Jan 2024 10:32:41 +0100 | Subject | Re: [PATCH v4 7/8] drm/panel: nt35510: move hardwired parameters to configuration |
| |
On Fri, Jan 5, 2024 at 8:08 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Thu, Jan 4, 2024 at 9:42 AM Dario Binacchi > <dario.binacchi@amarulasolutions.com> wrote: > > > This patch, preparatory for future developments, move the hardwired > > parameters to configuration data to allow the addition of new > > NT35510-based panels. > > > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > I tested this patch on the NT35510-based Skomer and it makes the > whole display mirrored around the Y-axis (text from right to left instead > of the other way around, penguins appear mirrored upper right > etc). > > + /* Enable TE, EoTP and RGB pixel format */ > + .dopctr = { NT35510_DOPCTR_0_DSITE | NT35510_DOPCTR_0_EOTP | > + NT35510_DOPCTR_0_N565, NT35510_DOPCTR_1_CTB }, > + .madctl = NT35510_ROTATE_180_SETTING, > > Changing this to NT35510_ROTATE_0_SETTING makes it work > fine again.
Sorry for the mistake
Thanks and regards, Dario Binacchi > > With that change: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Tested-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij
--
Dario Binacchi
Senior Embedded Linux Developer
dario.binacchi@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310 info@amarulasolutions.com
www.amarulasolutions.com
| |