Messages in this thread | | | Date | Fri, 26 Jan 2024 17:11:39 +0800 | Subject | Re: [PATCH v2] powerpc/cell: Code cleanup for spufs_mfc_flush | From | Kunwu Chan <> |
| |
On 2024/1/26 14:27, Arnd Bergmann wrote: > On Fri, Jan 26, 2024, at 03:12, Kunwu Chan wrote: >> This part was commented from commit a33a7d7309d7 >> ("[PATCH] spufs: implement mfc access for PPE-side DMA") >> in about 18 years before. >> >> If there are no plans to enable this part code in the future, >> we can remove this dead code. >> >> Signed-off-by: Kunwu Chan <chentao@kylinos.cn> >> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > Nobody is actively working on this code, so it clearly won't > be needed in the future. > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > On the other hand there is probably little use in removing > the dead code either. It looks you sent a lot of these > patches with identical changelog texts to remove blocks > of dead code, which does not seem productive to me as > these were clearly all left in the code to document > something. Yes, I was doing some cleanup of useless code the other day. The previous patches were submitted to remove some code that had been unused for a long time and was ineffective. I didn't remove the comments in the header file and the debugging-related parts. Because these parts may be used later.
Thank you very much for the reminder.I'll pay attention to whether it has a document feature later. > > Arnd -- Thanks, Kunwu
| |