lkml.org 
[lkml]   [2023]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 03/11] dt-bindings: riscv: add sophgo sg2042 bindings
    Regards,

    unicornx

    Conor Dooley <conor@kernel.org> 于2023年9月21日周四 20:18写道:
    >
    > On Thu, Sep 21, 2023 at 06:21:08PM +0800, Chen Wang wrote:
    > > Conor Dooley <conor.dooley@microchip.com> 于2023年9月20日周三 16:29写道:
    > > > On Wed, Sep 20, 2023 at 02:37:51PM +0800, Chen Wang wrote:
    > > > > Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
    > > > > Milk-V Pioneer board [2].
    > > > >
    > > > > [1]: https://en.sophgo.com/product/introduce/sg2042.html
    > > > > [2]: https://milkv.io/pioneer
    > > >
    > > > Again, link tags please.
    > > >
    > > > > Acked-by: Chao Wei <chao.wei@sophgo.com>
    > > > > Acked-by: Xiaoguang Xing <xiaoguang.xing@sophgo.com>
    > > > > Signed-off-by: Chen Wang <wangchen20@iscas.ac.cn>
    > > > > ---
    > > > > .../devicetree/bindings/riscv/sophgo.yaml | 28 +++++++++++++++++++
    > > > > MAINTAINERS | 7 +++++
    > > > > 2 files changed, 35 insertions(+)
    > > > > create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
    > > > >
    > > > > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
    > > > > new file mode 100644
    > > > > index 000000000000..82468ae915db
    > > > > --- /dev/null
    > > > > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
    > > > > @@ -0,0 +1,28 @@
    > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > > > > +%YAML 1.2
    > > > > +---
    > > > > +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
    > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > > > > +
    > > > > +title: Sophgo SoC-based boards
    > > > > +
    > > > > +maintainers:
    > > > > + - Chao Wei <chao.wei@sophgo.com>
    > > > > + - Xiaoguang Xing <xiaoguang.xing@sophgo.com>
    > > > > +
    > > > > +description:
    > > > > + Sophgo SoC-based boards
    > > > > +
    > > > > +properties:
    > > > > + $nodename:
    > > > > + const: '/'
    > > > > + compatible:
    > > > > + oneOf:
    > > > > + - items:
    > > > > + - enum:
    > > > > + - milkv,pioneer
    > > > > + - const: sophgo,sg2042
    > > > > +
    > > > > +additionalProperties: true
    > > > > +
    > > > > +...
    > > > > diff --git a/MAINTAINERS b/MAINTAINERS
    > > > > index 90f13281d297..b74d505003e2 100644
    > > > > --- a/MAINTAINERS
    > > > > +++ b/MAINTAINERS
    > > > > @@ -20063,6 +20063,13 @@ F: drivers/char/sonypi.c
    > > > > F: drivers/platform/x86/sony-laptop.c
    > > > > F: include/linux/sony-laptop.h
    > > > >
    > > > > +SOPHGO DEVICETREES
    > > > > +M: Xiaoguang Xing <xiaoguang.xing@sophgo.com>
    > > > > +M: Chao Wei <chao.wei@sophgo.com>
    > > > > +S: Maintained
    > > > > +F: Documentation/devicetree/bindings/riscv/sophgo.yaml
    > > >
    > > > > +F: arch/riscv/boot/dts/sophgo/
    > > >
    > > > Firstly, this directory does not exist at the time of this patch, so it
    > > > should not be added here, but rather at the time that you create it.
    > > >
    > > > Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
    > > > apply patches for these files? If so, you should add a git tree here
    > > > that they will apply patches to & add to linux-next. Also, I'd really
    > > > like to see some on-list signs of life from these people, otherwise
    > > > I'd rather see your name here instead of theirs.
    > > >
    > > > If they don't intend reviewing/testing/applying patches, I can do it as
    > > > a last resort but I would rather that someone who specifically cares for
    > > > this hardware does it.
    > >
    > > Please allow me to explain first. As a community volunteer, I actually
    > > had full discussions and testing with Sophgo people when submitting
    > > patches, so I added tag such "Acked-by: Xiaoguang Xing ..." to the
    > > signature part of most patches. Also if you think a formal email is
    > > required, I will talk them to send it.
    >
    > No, I'm okay with the acks that are on these patches. I just want to
    > make sure that those who are acking know why they are & am wondering why
    > your name is not there, seeing as you're the one who has submitted these
    > patches.
    >
    > > As for the issue of MAINTAINERS, I discussed it with the people from
    > > Sophgo. They (including me also) feel that we are not very familiar
    > > with the community process (especially as maintainer, and actually I
    > > modify the file MAINTAINERS is just to suppress warning information
    > > when running checkpatch.pl), so we sincerely hope to invite you, Mr.
    > > Conor,
    >
    > Oh god, there's no need to call me "Mr. Conor". Conor will do perfectly
    > fine!
    >
    > > to help us for a period of time on maintenance work, including
    > > checking relevant patches, merging and submitting PRs, we will learn
    > > together with you for a while, and then take over this part of the
    > > work when we become familiar with it. We know that you are also very
    > > busy at work, especially if you don't have the hardware at hand. I
    > > have the hardware here and I can take the responsibility to run
    > > testing. What do you think? I'm waiting for your reply. Thanks in
    > > advance.
    >
    > That seems fine to me. In that case, you should add yourself to the
    > MAINTAINERS entry.
    >
    > Thanks,
    > Conor.

    Okay,I will add it in next revision, thank you again.

    \
     
     \ /
      Last update: 2023-09-21 23:07    [W:2.677 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site