lkml.org 
[lkml]   [2023]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2] net: ti: icssg_prueth: add TAPRIO offload support
> > +	if (!netif_running(ndev)) {
> > + netdev_err(ndev, "interface is down, link speed unknown\n");
> > + return -ENETDOWN;
> > + }
>
> Do we really need this?

The error message suggests it is wrong anyway. netif_running() being
true means it is admin up. But the carrier might be down, and so the
link speed is unknown. So maybe this should be using netif_carrier_ok() ?

Andrew

\
 
 \ /
  Last update: 2023-09-21 22:33    [W:0.195 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site