Messages in this thread | | | Date | Thu, 21 Sep 2023 16:04:27 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v4 4/6] mm: Add structure to keep sva information |
| |
On Tue, Sep 12, 2023 at 08:59:34PM +0800, Tina Zhang wrote: > Introduce iommu_mm_data structure to keep sva information (pasid and the > related sva domains). Add iommu_mm pointer, pointing to an instance of > iommu_mm_data structure, to mm. > > Reviewed-by: Vasant Hegde <vasant.hegde@amd.com> > Signed-off-by: Tina Zhang <tina.zhang@intel.com> > --- > include/linux/iommu.h | 5 +++++ > include/linux/mm_types.h | 2 ++ > 2 files changed, 7 insertions(+)
This is not a great way to structure the patches
This patch should move the pasid into the struct and do all the infrastructure to allocate/free the struct.
The next patch should just add the list head to the now existing struct:
> +struct iommu_mm_data { > + u32 pasid; > + struct list_head sva_domains; > +};
The code looks fine though
Jason
| |