Messages in this thread | | | Date | Thu, 21 Sep 2023 11:58:38 +0100 | From | Lee Jones <> | Subject | Re: 回覆: [PATCH V 6 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA |
| |
On Tue, 19 Sep 2023, Larry Lai wrote:
> Hi Linus, > > Thank you for spending time to review the V6 patch, for your question, please kindly to check our comments with ">>" beginning.
I don't know about anyone else, but I'm finding this format hard to read. A full conversation using this style would be impossible to decipher.
Please can you configure your editor/client to quote and reply properly? That way previous responses and your comments can be easily differentiated.
> 寄件者: Linus Walleij <linus.walleij@linaro.org> > 寄件日期: 2023年9月15日 下午 05:02 > 收件者: Larry Lai <larry.lai@yunjingtech.com> > 副本: lee@kernel.org <lee@kernel.org>; andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com>; pavel@ucw.cz <pavel@ucw.cz>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; linux-gpio@vger.kernel.org <linux-gpio@vger.kernel.org>; linux-leds@vger.kernel.org <linux-leds@vger.kernel.org>; GaryWang@aaeon.com.tw <GaryWang@aaeon.com.tw>; Musa Lin <musa.lin@yunjingtech.com>; Jack Chang <jack.chang@yunjingtech.com>; Noah Hung <noah.hung@yunjingtech.com> > 主旨: Re: [PATCH V6 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA
Your client should automatically strip this from the mail body. > > On Fri, Sep 15, 2023 at 5:12 AM larry.lai <larry.lai@yunjingtech.com> wrote: > > > The UP Squared board <http://www.upboard.com> implements certain > > features (pin control) through an on-board FPGA. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Gary Wang <garywang@aaeon.com.tw> > > Signed-off-by: larry.lai <larry.lai@yunjingtech.com> > > This v6 overall looks good to me! > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Can the patch be merged on its own? > > > +#include "core.h" > > +#include "intel/pinctrl-intel.h" > > Didn't notice this before. But if Andy is OK with it, I'm > OK with it, I guess there is a reason? Perhaps it warrants > a comment explaining why you do this? > >> > Need struct intel_pinctrl gpp information to control dedicated Raspberry Pi compatible GPIOs. > These products (Up boards) are intel approves foundation kits. > > Valid reasons: > - You are using Intel-specific HW features also found in this > FPGA > > Invalid reasons: > - Using nifty macros or helpers, then either make them generic > or (if they are small) duplicate them. > > If it was that thing I asked Andy to keep locally because I didn't > agree with its generic usefulness, maybe I should be told to > reconsider. > > Yours, > Linus Walleij
-- Lee Jones [李琼斯]
| |