Messages in this thread | | | Date | Thu, 21 Sep 2023 23:29:14 +0200 | From | Greg KH <> | Subject | Re: [PATCH 4/4] tty: 8250: Add more support for and fix up Brainboxes cards |
| |
On Thu, Sep 21, 2023 at 10:13:33PM +0100, Cameron Williams wrote: > Add support for the rest of the Brainboxes range of serial cards, > except the 3-port variants as there is no suitable configuration > in this driver. > > - The pci_ids.h file has been updated to define each card's ID, cleaner > than using the raw ID.
That's not happening in this patch, are you sure you got this correct?
> - IntaShield IS-200 PCI ID comment corrected > - Added some missing device revision IDs > - All Oxford Semiconductor-based revisions of the cards had broken baud > rates, as they were tested against the same card on another PC which had > the same broken baud rate. After adding the correct init and setup quirks > these have now been re-tested against a third-party FTDI-based USB > converter and work fine. Thanks to Maciej W. Rozycki for clarification on > this IC.
This all needs to be broken up into smaller changes, one per logical thing, for us to be able to take them.
thanks,
greg k-h
| |