Messages in this thread | | | Date | Thu, 21 Sep 2023 10:52:48 +0200 | Subject | Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time undefined reference errors | From | Przemek Kitszel <> |
| |
On 9/20/23 20:07, Alexander Lobakin wrote: > Recently, several link-time issues were spotted in the ethernet/intel/ > folder thanks to Kbuild bots and linux-next. > The fixes are pretty straightforward, just some stubs and CONFIG_* > guards, so resolve all of them in one shot and unbreak randconfig > builds. > > Alexander Lobakin (3): > ice: fix undefined references to ice_is_*() when > !CONFIG_PTP_1588_CLOCK > ice: fix undefined references from DPLL code when > !CONFIG_PTP_1588_CLOCK > idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET > > drivers/net/ethernet/intel/ice/Makefile | 5 ++--- > drivers/net/ethernet/intel/ice/ice_main.c | 8 ++++--- > drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++- > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 3 +++ > 4 files changed, 34 insertions(+), 7 deletions(-) > > --- > Directly to netdev/net-next, build bots are not happy and the next > linux-next is approaching :s
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
I like the `if (IS_ENABLED(xxx))` approach more than stubs :)
| |