lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 5/9] tty: n_gsm: increase malformed counter for malformed control frames
    Date
    From: Daniel Starke <daniel.starke@siemens.com>

    The malformed counter in gsm_mux is already increased in case of errors
    detected in gsm_queue() and gsm1_receive(). gsm_dlci_command() also
    detects a case for a malformed frame but does not increase the malformed
    counter yet.

    Fix this by also increasing the gsm_mux malformed counter in case of a
    malformed frame in gsm_dlci_command().
    Note that the malformed counter is not yet exposed and only set internally.

    Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
    ---
    drivers/tty/n_gsm.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    v5 -> v6:
    No changes.

    Link: https://lore.kernel.org/all/20230517155704.5701-5-daniel.starke@siemens.com/

    diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
    index d28465f142a8..18f022f75831 100644
    --- a/drivers/tty/n_gsm.c
    +++ b/drivers/tty/n_gsm.c
    @@ -2455,8 +2455,10 @@ static void gsm_dlci_command(struct gsm_dlci *dlci, const u8 *data, int len)
    data += dlen;

    /* Malformed command? */
    - if (clen > len)
    + if (clen > len) {
    + dlci->gsm->malformed++;
    return;
    + }

    if (command & 1)
    gsm_control_message(dlci->gsm, command, data, clen);
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-08-17 11:34    [W:2.859 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site