lkml.org 
[lkml]   [2022]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c
Date


> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Monday, September 19, 2022 12:03 PM
> To: Frank Li <frank.li@nxp.com>
> Cc: maz@kernel.org; tglx@linutronix.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org;
> s.hauer@pengutronix.de; kw@linux.com; bhelgaas@google.com; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-pci@vger.kernel.org; Peng Fan
> <peng.fan@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>;
> jdmason@kudzu.us; kernel@pengutronix.de; festevam@gmail.com; dl-linux-
> imx <linux-imx@nxp.com>; kishon@ti.com; lorenzo.pieralisi@arm.com;
> ntb@lists.linux.dev; lznuaa@gmail.com; imx@lists.linux.dev;
> manivannan.sadhasivam@linaro.org
> Subject: [EXT] Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c
>
> Caution: EXT Email
>
> In subject (I mentioned this last time, too):
>
> PCI: endpoint: pci-epf-vntb: Clean up
>
> On Mon, Sep 19, 2022 at 10:40:37AM -0500, Frank Li wrote:
> > Remove unused field: epf_db_phy.
> > Remove __iomem before epf_db.
> > Change epf_db to u32* from void *
> > Remove dupicate check if (readl(ntb->epf_db + i * 4)).
>
> s/dupicate/duplicate/
>
> > Using sizeof(u32) instead of number 4 at all place.
> >
> > Clean up sparse build warning
> > Using epf_db[i] instead of readl() because epf_db is located in local
> memory
> > and allocated by dma_alloc_coherent()
>
> Is "Using epf_db[i] ..." an sparse warning? The indentation suggests
> that it is, but it doesn't seem related.

[Frank Li] sparse warning about __IOMEM. Dma_alloc_conherece()
Return void *. Not void __IOMEM *.

Readl() use void __IOMEM *.

Epf_db[i] is more simple and have not memory order risk here.

>
> > Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error
> handle path
> > to match pci_epf_alloc_space().
> >
> > Cleanup warning found by scripts/kernel-doc
> > Fix indentation of the struct epf_ntb_ctrl
> > Consildate term
>
> s/Consildate/Consolidate/
>
> > host, host1 to HOST
> > vhost, vHost, Vhost, VHOST2 to VHOST

\
 
 \ /
  Last update: 2022-09-19 19:10    [W:0.042 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site