Messages in this thread | ![/](/images/icornerl.gif) | | From | Namhyung Kim <> | Date | Wed, 6 Jan 2021 16:38:19 +0900 | Subject | Re: [PATCH v2 02/11] perf c2c: Add dimensions for load hit |
| |
On Sun, Dec 13, 2020 at 10:39 PM Leo Yan <leo.yan@linaro.org> wrote: > > Add dimensions for load hit and its percentage calculation, which is to > be displayed in the single cache line output. > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > --- > tools/perf/builtin-c2c.c | 71 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c > index 3d5a2dc8b4fd..00014e3d81fa 100644 > --- a/tools/perf/builtin-c2c.c > +++ b/tools/perf/builtin-c2c.c > @@ -1052,6 +1052,58 @@ percent_lcl_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused, > return per_left - per_right; > } > > +static double percent_ld_hit(struct c2c_hist_entry *c2c_he) > +{ > + struct c2c_hists *hists; > + int tot, st; > + > + hists = container_of(c2c_he->he.hists, struct c2c_hists, hists); > + > + st = TOT_LD_HIT(&c2c_he->stats); > + tot = TOT_LD_HIT(&hists->stats); > + > + return percent(st, tot);
It's not clear to me what's different than percent_tot_ld_hit().
Thanks, Namhyung
> +} > + > +static int > +percent_ld_hit_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, > + struct hist_entry *he) > +{ > + struct c2c_hist_entry *c2c_he; > + int width = c2c_width(fmt, hpp, he->hists); > + char buf[10]; > + double per; > + > + c2c_he = container_of(he, struct c2c_hist_entry, he); > + per = percent_ld_hit(c2c_he); > + return scnprintf(hpp->buf, hpp->size, "%*s", width, PERC_STR(buf, per)); > +} > + > +static int > +percent_ld_hit_color(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, > + struct hist_entry *he) > +{ > + return percent_color(fmt, hpp, he, percent_ld_hit); > +} > + > +static int64_t > +percent_ld_hit_cmp(struct perf_hpp_fmt *fmt __maybe_unused, > + struct hist_entry *left, struct hist_entry *right) > +{ > + struct c2c_hist_entry *c2c_left; > + struct c2c_hist_entry *c2c_right; > + double per_left; > + double per_right; > + > + c2c_left = container_of(left, struct c2c_hist_entry, he); > + c2c_right = container_of(right, struct c2c_hist_entry, he); > + > + per_left = percent_ld_hit(c2c_left); > + per_right = percent_ld_hit(c2c_right); > + > + return per_left - per_right; > +} > + > static int > percent_stores_l1hit_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp, > struct hist_entry *he) > @@ -1417,6 +1469,14 @@ static struct c2c_dimension dim_cl_rmt_hitm = { > .width = 7, > }; > > +static struct c2c_dimension dim_cl_tot_ld_hit = { > + .header = HEADER_SPAN("--- Load ---", "Hit", 1), > + .name = "cl_tot_ld_hit", > + .cmp = tot_ld_hit_cmp, > + .entry = tot_ld_hit_entry, > + .width = 7, > +}; > + > static struct c2c_dimension dim_cl_lcl_hitm = { > .header = HEADER_SPAN_LOW("Lcl"), > .name = "cl_lcl_hitm", > @@ -1570,6 +1630,15 @@ static struct c2c_dimension dim_percent_tot_ld_hit = { > .width = 8, > }; > > +static struct c2c_dimension dim_percent_ld_hit = { > + .header = HEADER_SPAN("-- Load Refs --", "Hit", 1), > + .name = "percent_ld_hit", > + .cmp = percent_ld_hit_cmp, > + .entry = percent_ld_hit_entry, > + .color = percent_ld_hit_color, > + .width = 7, > +}; > + > static struct c2c_dimension dim_percent_stores_l1hit = { > .header = HEADER_SPAN("-- Store Refs --", "L1 Hit", 1), > .name = "percent_stores_l1hit", > @@ -1715,6 +1784,7 @@ static struct c2c_dimension *dimensions[] = { > &dim_rmt_hitm, > &dim_cl_lcl_hitm, > &dim_cl_rmt_hitm, > + &dim_cl_tot_ld_hit, > &dim_tot_stores, > &dim_stores_l1hit, > &dim_stores_l1miss, > @@ -1731,6 +1801,7 @@ static struct c2c_dimension *dimensions[] = { > &dim_percent_hitm, > &dim_percent_rmt_hitm, > &dim_percent_lcl_hitm, > + &dim_percent_ld_hit, > &dim_percent_tot_ld_hit, > &dim_percent_stores_l1hit, > &dim_percent_stores_l1miss, > -- > 2.17.1 >
| ![\](/images/icornerr.gif) |